Have gotten a bunch of PR’s this past week, since this is the last week of class. Everyone is finishing up their release 4, which means the project has made some great progress.
We now have the continuous integration system Travis, that helps with managing the app. And, we are working on es-lint and prettier, there is still some configuring to do but it’s almost up and running.
So with all the changes, there was a bit of backtracking I had to fix. One of the PR’s changed how the messages were sent to the screen but they forgot to change some corresponding code, so it ended up breaking the messages altogether so no messages would display correctly on the screen. It was a pretty easy fix, but I am not sure about keeping it. The change puts the JSX for a message into a variable, then we just render that. The problem with that is it doesn’t get updated anymore when state changes. I have to look into it more later, but I might have to go back to making the JSX just before it is rendered.
Here is the PR that fixed the above bug and a few others: https://github.com/OTRChat/NodeChat/pull/72.
The other bugs include:
- package.json – formatting bugs that formed when I did a manual merge.
- Fixed avatar’s so you can now upload custom avatars. This change required changes to the server aswell, this is the PR that changed the server https://github.com/OTRChat/server/pull/4.
- package-lock.json – There was a problem merging so I just deleted the old version and made a new one.